fix: history 内置Tag 加上统计总数的逻辑 - #4065
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the HTTP history UI to adjust how built-in tags are derived/filtered (using tag totals) and enables Chromium overlay scrollbars globally in the Electron main process to reduce layout jitter caused by scrollbar appearance/disappearance.
Changes:
- Remove
setBuiltinTagListprop plumbing fromHistoryProcesscall sites and stop destructuring the setter fromuseBuiltinTagList. - Filter tags returned by
HTTPFlowsFieldGroupto exclude certain built-in tags based onTotal. - Enable global overlay scrollbars via
app.commandLine.appendSwitch('enable-features', 'OverlayScrollbars').
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/renderer/src/main/src/pages/hTTPHistoryAnalysis/HTTPHistory/HTTPHistoryFilter.tsx | Stops passing setBuiltinTagList into HistoryProcess; continues using useBuiltinTagList for table built-in tag options. |
| app/renderer/src/main/src/components/HTTPHistory.tsx | Removes setBuiltinTagList prop from HistoryProcess and changes tag filtering logic to use Total for built-in tags. |
| app/main/index.js | Enables Chromium overlay scrollbars globally to avoid layout reflow/jitter from scrollbars. |
Comments suppressed due to low confidence (1)
app/renderer/src/main/src/components/HTTPHistory.tsx:972
!!item.Totaltreats0as falsy, so built-in tags with a valid count of 0 will be filtered out. If the intent is to only hide built-in tags with no data, use an explicit numeric comparison to avoid accidentally dropping0.
const tags = (rsp.Tags || []).filter(
(item) => !!item.Value && item.Value !== HTTP_FLOW_FAVORITE_TAG && (!item.Builtin || !!item.Total),
)
Contributor
PR CI 汇总状态：全部通过
由 pull_request test workflow 自动生成 |
hjhke
force-pushed
the
hejiahui/fix/BuildInTag
branch
from
July 29, 2026 03:47
9bb7bc6 to
c6a95db
Compare
hjhke
force-pushed
the
hejiahui/fix/BuildInTag
branch
2 times, most recently
from
July 30, 2026 06:28
9cd4fa9 to
883bd7b
Compare
hjhke
changed the title
hubin4826
approved these changes
Jul 31, 2026
song-xiao-lin
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第二个合并方式